Bug 37504 - Change a parameter type of chooseIconForFiles()
Summary: Change a parameter type of chooseIconForFiles()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-13 09:53 PDT by Kent Tamura
Modified: 2010-04-20 12:20 PDT (History)
3 users (show)

See Also:

Attachments
Proposed patch (16.52 KB, patch)
2010-04-13 12:44 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2010-04-13 09:53:30 PDT 
PassRefPtr<FileChoose> should be FileChoose*.
Though some implementations of ChromeClient::chooseIconForFiles() might have ownership of the FileChooser instance, we don't need to use PassRefPtr<>. Such implementations can store the FileChooser pointer to RefPtr<FileChooser>.
Comment 1 Kent Tamura 2010-04-13 12:44:23 PDT 
Created attachment 53273 [details]
Proposed patch
Comment 2 Kent Tamura 2010-04-13 12:46:38 PDT 
Probably we want to change it for Chrome::runOpenPanel() too?
Comment 3 WebKit Commit Bot 2010-04-20 12:20:20 PDT 
Comment on attachment 53273 [details]
Proposed patch

Clearing flags on attachment: 53273

Committed r57903: <http://trac.webkit.org/changeset/57903>
Comment 4 WebKit Commit Bot 2010-04-20 12:20:28 PDT 
All reviewed patches have been landed.  Closing bug.