Bug 37504 - Change a parameter type of chooseIconForFiles()
: Change a parameter type of chooseIconForFiles()
Status: RESOLVED FIXED
: WebKit
New Bugs
: 528+ (Nightly build)
: All All
: P2 Minor
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2010-04-13 09:53 PST by
Modified: 2010-04-20 12:20 PST (History)


Attachments
Proposed patch (16.52 KB, patch)
2010-04-13 12:44 PST, Kent Tamura
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2010-04-13 09:53:30 PST
PassRefPtr<FileChoose> should be FileChoose*.
Though some implementations of ChromeClient::chooseIconForFiles() might have ownership of the FileChooser instance, we don't need to use PassRefPtr<>. Such implementations can store the FileChooser pointer to RefPtr<FileChooser>.
------- Comment #1 From 2010-04-13 12:44:23 PST -------
Created an attachment (id=53273) [details]
Proposed patch
------- Comment #2 From 2010-04-13 12:46:38 PST -------
Probably we want to change it for Chrome::runOpenPanel() too?
------- Comment #3 From 2010-04-20 12:20:20 PST -------
(From update of attachment 53273 [details])
Clearing flags on attachment: 53273

Committed r57903: <http://trac.webkit.org/changeset/57903>
------- Comment #4 From 2010-04-20 12:20:28 PST -------
All reviewed patches have been landed.  Closing bug.