Bug 37498

Summary:

Web Inspector: in Profiles panel, search always displays "Not found", although it jumps through the results

Product:

WebKit

Reporter:

Mikhail Naganov <mnaganov>

Component:

Web Inspector (Deprecated)

Assignee:

Mikhail Naganov <mnaganov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bweinstein, commit-queue, joepeck, keishi, pfeldman, pmuellr, rik, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Sample of search box incorrect bheavior	none
proposed patch	pfeldman: review-
comments addressed	none

Mikhail Naganov

Reported 2010-04-13 05:41:31 PDT

Created attachment 53240 [details] Sample of search box incorrect bheavior Open Inspector, enable profiling, and collect a profile. In the "Search Profiles" field, try to search for something existing, e.g. "(program)" or "(idle)". To the left of the box "Not Found" is displayed immediately. Interesting enough, that switching back and forth between panels (or between profile views), and then pressing "Enter" on the search box sometimes leads to showing search results and cursor jumping over them, but "Not Found" is still displayed (see the screenshot.)

Attachments
Sample of search box incorrect bheavior (163.30 KB, image/png) 2010-04-13 05:41 PDT, Mikhail Naganov	no flags	Details
proposed patch (2.38 KB, patch) 2010-04-13 07:13 PDT, Mikhail Naganov	pfeldman: review-	Details Formatted Diff Diff
comments addressed (2.21 KB, patch) 2010-04-13 11:01 PDT, Mikhail Naganov	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Mikhail Naganov

Comment 1 2010-04-13 07:13:17 PDT

Created attachment 53246 [details] proposed patch

Pavel Feldman

Comment 2 2010-04-13 07:25:18 PDT

Comment on attachment 53246 [details] proposed patch > + // The profile passed in the constructor contains important properties, but > + // no actual data. To have both properties and data, we chain the profile > + // we've got from 'getProfile' with the one passed in the constructor. > + profile.__proto__ = self.profile; Assigning proto is nothing but the hack. What you should do is to create an object with properties around the payload you've received just as it is done in case of DOMAgent.js.

Mikhail Naganov

Comment 3 2010-04-13 11:01:39 PDT

Created attachment 53264 [details] comments addressed

Pavel Feldman

Comment 4 2010-04-13 11:09:53 PDT

Comment on attachment 53264 [details] comments addressed Much better!

WebKit Commit Bot

Comment 5 2010-04-13 12:14:28 PDT

Comment on attachment 53264 [details] comments addressed Clearing flags on attachment: 53264 Committed r57529: <http://trac.webkit.org/changeset/57529>

WebKit Commit Bot

Comment 6 2010-04-13 12:14:34 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.