| Summary: | Web Inspector: in Profiles panel, search always displays "Not found", although it jumps through the results | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mikhail Naganov <mnaganov> | ||||||||
| Component: | Web Inspector (Deprecated) | Assignee: | Mikhail Naganov <mnaganov> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bweinstein, commit-queue, joepeck, keishi, pfeldman, pmuellr, rik, timothy | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 53246 [details]
proposed patch
Comment on attachment 53246 [details] proposed patch > + // The profile passed in the constructor contains important properties, but > + // no actual data. To have both properties and data, we chain the profile > + // we've got from 'getProfile' with the one passed in the constructor. > + profile.__proto__ = self.profile; Assigning proto is nothing but the hack. What you should do is to create an object with properties around the payload you've received just as it is done in case of DOMAgent.js. Created attachment 53264 [details]
comments addressed
Comment on attachment 53264 [details]
comments addressed
Much better!
Comment on attachment 53264 [details] comments addressed Clearing flags on attachment: 53264 Committed r57529: <http://trac.webkit.org/changeset/57529> All reviewed patches have been landed. Closing bug. |
Created attachment 53240 [details] Sample of search box incorrect bheavior Open Inspector, enable profiling, and collect a profile. In the "Search Profiles" field, try to search for something existing, e.g. "(program)" or "(idle)". To the left of the box "Not Found" is displayed immediately. Interesting enough, that switching back and forth between panels (or between profile views), and then pressing "Enter" on the search box sometimes leads to showing search results and cursor jumping over them, but "Not Found" is still displayed (see the screenshot.)