Bug 37490

Summary:

Add URL anchor tests from Google URL

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Layout Test	none

Daniel Bates

Reported 2010-04-12 22:24:42 PDT

We should implement the URL anchor tests from <http://code.google.com/p/google-url/source/browse/trunk/src/url_canon_unittest.cc#1102>.

Attachments
Layout Test (3.55 KB, patch) 2010-04-12 22:26 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2010-04-12 22:26:36 PDT

Created attachment 53223 [details] Layout Test

Adam Barth

Comment 2 2010-04-12 22:56:28 PDT

Comment on attachment 53223 [details] Layout Test Thanks Dan. I'm not sure we're doing the crazy charset ones correctly. We might need to set the charset for the page to UTF8. Do these pass in Chrome? Another possibility (actually, this is more likely) is that we need to find the UTF16 codepoints for these character. Maybe use the ones from the L strings?

WebKit Commit Bot

Comment 3 2010-04-12 23:09:46 PDT

Comment on attachment 53223 [details] Layout Test Clearing flags on attachment: 53223 Committed r57502: <http://trac.webkit.org/changeset/57502>

WebKit Commit Bot

Comment 4 2010-04-12 23:09:51 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.