|Summary:||Add query string tests from Google URL|
|Product:||WebKit||Reporter:||Daniel Bates <dbates>|
|Component:||Tools / Tests||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||abarth, commit-queue, joth|
|Version:||528+ (Nightly build)|
Description Daniel Bates 2010-04-12 19:54:57 PDT
We should implement at least all of the non-encoding specific query string tests from <http://code.google.com/p/google-url/source/browse/trunk/src/url_canon_unittest.cc#1016>.
Comment 2 Adam Barth 2010-04-12 20:23:15 PDT
Comment on attachment 53214 [details] Layout Test +<script src="resources/utilities.js"></script> I don't think we can edit these files because they are generated from the make-test-wrappers script. + ["as#df", "as%23df"], I don't think this result is correct, but I agree that we should just literally land what's in the unit tests. We can do a separate pass to understand the different behaviors here. Review- because we can't change the generated files. I think it's ok to copy/paste that small function between tests.
Comment 3 Daniel Bates 2010-04-12 20:28:59 PDT
Comment 4 Adam Barth 2010-04-12 20:35:43 PDT
Comment on attachment 53214 [details] Layout Test I stand corrected. You are awesome. Let's leave the test in. I'd like to do a pass through the whole test suite once we've got it checked in.
Comment 5 WebKit Commit Bot 2010-04-12 21:53:06 PDT
Comment on attachment 53214 [details] Layout Test Clearing flags on attachment: 53214 Committed r57501: <http://trac.webkit.org/changeset/57501>
Comment 6 WebKit Commit Bot 2010-04-12 21:53:12 PDT
All reviewed patches have been landed. Closing bug.
Comment 7 Jonathan Dixon 2010-04-12 23:37:48 PDT
Tip for the follow up pass: you can use http://rishida.net/tools/conversion/ to do the character set conversion utf 8 -> utf 16, e.g. q=\xe4\xbd\xa0\xe5\xa5\xbd translates to q=\u4F60\u597D in JS escaping. (i.e. enter "e4 bd a0 e5 a5 bd" into the UTF-8 code units box)
Comment 8 Adam Barth 2010-04-13 00:40:45 PDT