Bug 37473

Summary: WebKit should have more robust last-chance font fallback on Windows
Product: WebKit Reporter: Steve Falkenburg <sfalken>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch mitz: review+

Description Steve Falkenburg 2010-04-12 16:15:18 PDT
WebKit should have more robust last-chance font fallback on Windows
Comment 1 Steve Falkenburg 2010-04-12 16:41:12 PDT
Created attachment 53198 [details]
Patch
Comment 2 Steve Falkenburg 2010-04-12 16:45:22 PDT
Created attachment 53199 [details]
Patch
Comment 3 mitz 2010-04-12 17:00:12 PDT
Comment on attachment 53199 [details]
Patch

> +#if PLATFORM(WIN)
> +    SimpleFontData* FontCache::fontDataFromDescriptionAndLogFont(const FontDescription&, const LOGFONT&);
> +#endif

I’d avoid this method and replace it with a file-static function that takes a FontCache*, but r=me either way.
Comment 4 Steve Falkenburg 2010-04-12 17:48:14 PDT
Committed r57490: <http://trac.webkit.org/changeset/57490>