Bug 37473

Summary: WebKit should have more robust last-chance font fallback on Windows
Product: WebKit Reporter: Steve Falkenburg <sfalken>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch mitz: review+

Steve Falkenburg
Reported 2010-04-12 16:15:18 PDT
WebKit should have more robust last-chance font fallback on Windows
Attachments
Patch (5.56 KB, patch)
2010-04-12 16:41 PDT, Steve Falkenburg 		no flags
DetailsFormatted DiffDiff
Patch (5.56 KB, patch)
2010-04-12 16:45 PDT, Steve Falkenburg 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Steve Falkenburg
Comment 1 2010-04-12 16:41:12 PDT
Created attachment 53198 [details] Patch
Steve Falkenburg
Comment 2 2010-04-12 16:45:22 PDT
Created attachment 53199 [details] Patch
mitz
Comment 3 2010-04-12 17:00:12 PDT
Comment on attachment 53199 [details] Patch > +#if PLATFORM(WIN) > + SimpleFontData* FontCache::fontDataFromDescriptionAndLogFont(const FontDescription&, const LOGFONT&); > +#endif I’d avoid this method and replace it with a file-static function that takes a FontCache*, but r=me either way.
Steve Falkenburg
Comment 4 2010-04-12 17:48:14 PDT
Committed r57490: <http://trac.webkit.org/changeset/57490>
Note You need to log in before you can comment on or make changes to this bug.