Bug 37464

Summary: new-run-webkit-tests: run_webkit_tests.py should not call sys.exit()
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: Tools / TestsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cjerdonek, eric, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Dirk Pranke
Reported 2010-04-12 13:15:30 PDT
Current the run_webkit_tests.py script used by new-run-webkit-tests to do all the real work calls sys.exit(). This makes it difficult to call the functions repeatedly for unit testing, and is kind of a goofy layering violation. The exit call should be pushed up into the main new-run-webkit-tests script.
Attachments
Patch (4.02 KB, patch)
2010-04-12 14:13 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2010-04-12 14:13:43 PDT
Created attachment 53186 [details] Patch
Eric Seidel (no email)
Comment 2 2010-04-12 16:06:38 PDT
Comment on attachment 53186 [details] Patch OK.
Dirk Pranke
Comment 3 2010-04-12 16:15:17 PDT
Comment on attachment 53186 [details] Patch Clearing flags on attachment: 53186 Committed r57486: <http://trac.webkit.org/changeset/57486>
Dirk Pranke
Comment 4 2010-04-12 16:15:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.