Bug 37411

Summary: [Haiku] Improve SimpleFontDataHaiku implementation
Product: WebKit Reporter: Stephan Aßmus <superstippi>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
[Haiku] Improve SimpleFontDataHaiku.cpp none

Stephan Aßmus
Reported 2010-04-11 07:53:43 PDT
* Removed a hack and replaced it with existing UTF8 encoding infrastructure. * Fixed a memory leak.
Attachments
[Haiku] Improve SimpleFontDataHaiku.cpp (3.21 KB, patch)
2010-04-11 07:55 PDT, Stephan Aßmus 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Stephan Aßmus
Comment 1 2010-04-11 07:55:37 PDT
Created attachment 53089 [details] [Haiku] Improve SimpleFontDataHaiku.cpp
WebKit Commit Bot
Comment 2 2010-04-13 22:15:00 PDT
Comment on attachment 53089 [details] [Haiku] Improve SimpleFontDataHaiku.cpp Rejecting patch 53089 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 12673 test cases. fast/events/platform-wheelevent-in-scrolling-div.html -> failed Exiting early after 1 failures. 6453 tests run. 117.11s total testing time 6452 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 2 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/1601449
Eric Seidel (no email)
Comment 3 2010-04-21 18:26:10 PDT
Comment on attachment 53089 [details] [Haiku] Improve SimpleFontDataHaiku.cpp Flaky test.
WebKit Commit Bot
Comment 4 2010-04-22 00:30:09 PDT
Comment on attachment 53089 [details] [Haiku] Improve SimpleFontDataHaiku.cpp Clearing flags on attachment: 53089 Committed r58068: <http://trac.webkit.org/changeset/58068>
WebKit Commit Bot
Comment 5 2010-04-22 00:30:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.