Bug 37407

Summary:

Make commit-log-editor Rubber-stamp aware. And other minor cleanups.

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

joepeck

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
[PATCH] Rubber Stamp support and Cleanup	mrowe: review+

Joseph Pecoraro

Reported 2010-04-11 00:34:15 PDT

commit-log-editor doesn't treat a "Rubber-stamp by" like a "Reviewed by". This causes ugly output.

Attachments
[PATCH] Rubber Stamp support and Cleanup (2.12 KB, patch) 2010-04-11 00:37 PDT, Joseph Pecoraro	mrowe: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2010-04-11 00:37:07 PDT

Created attachment 53080 [details] [PATCH] Rubber Stamp support and Cleanup Handles the top 3 Rubber-stamp variants: "Rubber-stamped by" "Rubber stamped by" "Rubberstamped by" Also removes some old code, fixes style issues, and provides better error messages.

Mark Rowe (bdash)

Comment 2 2010-04-11 00:38:17 PDT

Comment on attachment 53080 [details] [PATCH] Rubber Stamp support and Cleanup Sure, why not.

Joseph Pecoraro

Comment 3 2010-04-11 00:47:22 PDT

Committed r57447 M WebKitTools/ChangeLog M WebKitTools/Scripts/commit-log-editor r57447 = 3242d4a0dd22da53cd7f7fd35de11fd0272a3489 (trunk) http://trac.webkit.org/changeset/57447

Note You need to log in before you can comment on or make changes to this bug.