Bug 37405

Summary: kill_process is copy/pasted in five places
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch eric: review+

Adam Barth
Reported 2010-04-10 23:27:05 PDT
kill_process is copy/pasted in five places
Attachments
Patch (8.02 KB, patch)
2010-04-10 23:29 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (9.41 KB, patch)
2010-04-10 23:46 PDT, Adam Barth 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-04-10 23:29:43 PDT
Created attachment 53077 [details] Patch
Eric Seidel (no email)
Comment 2 2010-04-10 23:31:41 PDT
Comment on attachment 53077 [details] Patch REALLY? Assuming you didn't just break the world... OK.
Eric Seidel (no email)
Comment 3 2010-04-10 23:32:20 PDT
Comment on attachment 53077 [details] Patch http://docs.python.org/library/os.html claims it only works on UNIX.
Eric Seidel (no email)
Comment 4 2010-04-10 23:32:43 PDT
Just move it all to Executive, then we can kill it later if needed.
Adam Barth
Comment 5 2010-04-10 23:46:49 PDT
Created attachment 53078 [details] Patch
Eric Seidel (no email)
Comment 6 2010-04-10 23:51:34 PDT
Comment on attachment 53078 [details] Patch LGTM.
Adam Barth
Comment 7 2010-04-10 23:52:30 PDT
Committed r57444: <http://trac.webkit.org/changeset/57444>
Note You need to log in before you can comment on or make changes to this bug.