Bug 37405 - kill_process is copy/pasted in five places
Summary: kill_process is copy/pasted in five places
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-10 23:27 PDT by Adam Barth
Modified: 2010-04-10 23:52 PDT (History)
2 users (show)

See Also:


Attachments
Patch (8.02 KB, patch)
2010-04-10 23:29 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (9.41 KB, patch)
2010-04-10 23:46 PDT, Adam Barth
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-04-10 23:27:05 PDT
kill_process is copy/pasted in five places
Comment 1 Adam Barth 2010-04-10 23:29:43 PDT
Created attachment 53077 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-04-10 23:31:41 PDT
Comment on attachment 53077 [details]
Patch

REALLY?  Assuming you didn't just break the world... OK.
Comment 3 Eric Seidel (no email) 2010-04-10 23:32:20 PDT
Comment on attachment 53077 [details]
Patch

http://docs.python.org/library/os.html claims it only works on UNIX.
Comment 4 Eric Seidel (no email) 2010-04-10 23:32:43 PDT
Just move it all to Executive, then we can kill it later if needed.
Comment 5 Adam Barth 2010-04-10 23:46:49 PDT
Created attachment 53078 [details]
Patch
Comment 6 Eric Seidel (no email) 2010-04-10 23:51:34 PDT
Comment on attachment 53078 [details]
Patch

LGTM.
Comment 7 Adam Barth 2010-04-10 23:52:30 PDT
Committed r57444: <http://trac.webkit.org/changeset/57444>