Bug 37374

Summary: Clean up chromium WebNotificationPresenter interface after chromium breakage
Product: WebKit Reporter: Rafael Weinstein <rafaelw>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fishd, johnnyg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Rafael Weinstein
Reported 2010-04-09 16:47:05 PDT
Webkit patch https://bugs.webkit.org/show_bug.cgi?id=36904 broke the chromium port because of argument mismatch. Darin fixed the breakage by adding default implementations in http://trac.webkit.org/changeset/57046. I have since landed http://src.chromium.org/viewvc/chrome?view=rev&revision=43735 in chromium so that renderer/notification_provider requestPermission takes a WebSecurityOrigin. This attached patch returns the WebNotificationPresenter to being a pure virtual (abstract) interface.
Attachments
Patch (2.11 KB, patch)
2010-04-09 16:48 PDT, Rafael Weinstein 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rafael Weinstein
Comment 1 2010-04-09 16:48:51 PDT
Created attachment 53015 [details] Patch
Eric Seidel (no email)
Comment 2 2010-04-10 15:51:48 PDT
Comment on attachment 53015 [details] Patch OK. Darin is CC'd so he'll see this go by.
WebKit Commit Bot
Comment 3 2010-04-10 18:16:27 PDT
Comment on attachment 53015 [details] Patch Clearing flags on attachment: 53015 Committed r57431: <http://trac.webkit.org/changeset/57431>
WebKit Commit Bot
Comment 4 2010-04-10 18:16:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.