Bug 37368

Summary: Add MiniBrowser for new WebKit API
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch andersca: review+

Sam Weinig
Reported 2010-04-09 15:33:34 PDT
Created attachment 53002 [details] Patch Add MiniBrowser for new WebKit API.
Attachments
Patch (305.71 KB, patch)
2010-04-09 15:33 PDT, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-04-09 15:35:30 PDT
Comment on attachment 53002 [details] Patch r=me
WebKit Review Bot
Comment 2 2010-04-09 15:36:05 PDT
Attachment 53002 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit2/MiniBrowser/win/main.cpp:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/MiniBrowser/win/main.cpp:28: Alphabetical sorting problem. [build/include_order] [4] WebKit2/MiniBrowser/mac/BrowserWindowController.h:36: _pageNamespace is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/MiniBrowser/win/MiniBrowser.cpp:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/MiniBrowser/win/MiniBrowser.cpp:27: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/MiniBrowser/win/resource.h:1: Should have a space between // and comment [whitespace/comments] [4] WebKit2/MiniBrowser/win/stdafx.cpp:30: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/MiniBrowser/win/BrowserView.cpp:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/MiniBrowser/win/BrowserView.cpp:27: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/MiniBrowser/win/BrowserWindow.cpp:26: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/MiniBrowser/win/BrowserWindow.cpp:27: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 11 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
Anders Carlsson
Comment 3 2010-04-09 15:46:02 PDT
Actually, could you put MiniBrowser in WebKitTools instead? Thanks!
Sam Weinig
Comment 4 2010-04-09 15:48:58 PDT
Landed in r57374.
Note You need to log in before you can comment on or make changes to this bug.