Bug 37367

Summary:

Make Generated V8 code adhere to webkit style

Product:

WebKit

Reporter:

Yaar Schnitman <yaar>

Component:

WebKit Misc.

Assignee:

Nate Chapin <japhet>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dglazkov, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
patch	dglazkov: review+

Yaar Schnitman

Reported 2010-04-09 15:29:56 PDT

I almost adheres, but there are a few things it doesn't.

Attachments
patch (50.57 KB, patch) 2010-04-20 15:58 PDT, Nate Chapin	dglazkov: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Nate Chapin

Comment 1 2010-04-20 15:58:32 PDT

Created attachment 53901 [details] patch This also fixes a bunch of style violations the TestObj.idl doesn't trigger. I ran check-webkit-style over the entire generated bindings, and there now is only a single violation (in V8DOMWindow.cpp), which would be non-trivial to resolve and probably cause the script to become substantially less readable.

Dimitri Glazkov (Google)

Comment 2 2010-04-20 16:05:54 PDT

Comment on attachment 53901 [details] patch awesome. Thanks!

Nate Chapin

Comment 3 2010-04-20 16:29:07 PDT

http://trac.webkit.org/changeset/57936

WebKit Review Bot

Comment 4 2010-04-20 20:53:39 PDT

Note You need to log in before you can comment on or make changes to this bug.