Bug 37367

Summary: Make Generated V8 code adhere to webkit style
Product: WebKit Reporter: Yaar Schnitman <yaar>
Component: WebKit Misc.Assignee: Nate Chapin <japhet>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch dglazkov: review+

Description Yaar Schnitman 2010-04-09 15:29:56 PDT
I almost adheres, but there are a few things it doesn't.
Comment 1 Nate Chapin 2010-04-20 15:58:32 PDT
Created attachment 53901 [details]
patch

This also fixes a bunch of style violations the TestObj.idl doesn't trigger.  I ran check-webkit-style over the entire generated bindings, and there now is only a single violation (in V8DOMWindow.cpp), which would be non-trivial to resolve and probably cause the script to become substantially less readable.
Comment 2 Dimitri Glazkov (Google) 2010-04-20 16:05:54 PDT
Comment on attachment 53901 [details]
patch

awesome. Thanks!
Comment 3 Nate Chapin 2010-04-20 16:29:07 PDT
http://trac.webkit.org/changeset/57936