Bug 37347 – Don't use CF types in the new C API

• Component: New Bugs
• Status: RESOLVED FIXED

[Sam Weinig]

Created attachment 52971 [details]
Patch

Use WK types instead.

[Anders Carlsson]

Comment on attachment 52971 [details]
Patch


> +    WebCore::KURL& url() { return m_url; }

This should be const. Looks good otherwise.

r=me

[Geoffrey Garen]

The KURLWrapper::create boilerplate here is unfortunate. It would be better if KURL itself were refcounted, like StringImpl. That would avoid an allocation at the API boundary, too.

Same goes for ResourceRequest, ResourceResponse, etc.

[Brady Eidson]

(In reply to comment #2)
> The KURLWrapper::create boilerplate here is unfortunate. It would be better if
> KURL itself were refcounted, like StringImpl. That would avoid an allocation at
> the API boundary, too.
> 
> Same goes for ResourceRequest, ResourceResponse, etc.

Indeed, it would be good for WebCore as a cross-platform whole if that were the case.

[Sam Weinig]

Fixed in r57352.