Bug 3727

Summary: Patch for decoder.cpp to compile with DECODE_DEBUG
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit Misc.Assignee: Chris Blumenberg <cblu>
Status: VERIFIED FIXED    
Severity: Trivial    
Priority: P2    
Version: 412   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed patch darin: review+

Alexey Proskuryakov
Reported 2005-06-26 11:19:54 PDT
When a DECODE_DEBUG preprocessor symbol is defined in khtml/misc/decoder.cpp, compilation fails because a non-existent variable "force" is used. This patch fixes this, and also a missing space in another debug string.
Attachments
proposed patch (962 bytes, patch)
2005-06-26 11:20 PDT, Alexey Proskuryakov 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2005-06-26 11:20:36 PDT
Created attachment 2655 [details] proposed patch
Darin Adler
Comment 2 2005-06-26 23:35:33 PDT
Comment on attachment 2655 [details] proposed patch Seems nice to fix this. However, please note that we don't have kdDebug implemented to do anything.
Alexey Proskuryakov
Comment 3 2005-06-27 06:15:26 PDT
Yes, I have created a simple implementation of kDebug to aid in debugging Decoder. I'm not sure if it needs to be added to WebKit (definitely not in its current state :) ).
Note You need to log in before you can comment on or make changes to this bug.