Bug 3727 - Patch for decoder.cpp to compile with DECODE_DEBUG
Summary: Patch for decoder.cpp to compile with DECODE_DEBUG
Status: VERIFIED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 412
Hardware: All All
: P2 Trivial
Assignee: Chris Blumenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-26 11:19 PDT by Alexey Proskuryakov
Modified: 2005-07-02 03:17 PDT (History)
0 users

See Also:

Attachments
proposed patch (962 bytes, patch)
2005-06-26 11:20 PDT, Alexey Proskuryakov 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2005-06-26 11:19:54 PDT 
When a DECODE_DEBUG preprocessor symbol is defined in khtml/misc/decoder.cpp, compilation fails 
because a non-existent variable "force" is used. This patch fixes this, and also a missing space in another 
debug string.
Comment 1 Alexey Proskuryakov 2005-06-26 11:20:36 PDT 
Created attachment 2655 [details]
proposed patch
Comment 2 Darin Adler 2005-06-26 23:35:33 PDT 
Comment on attachment 2655 [details]
proposed patch

Seems nice to fix this.

However, please note that we don't have kdDebug implemented to do anything.
Comment 3 Alexey Proskuryakov 2005-06-27 06:15:26 PDT 
Yes, I have created a simple implementation of kDebug to aid in debugging Decoder. I'm not sure if it 
needs to be added to WebKit (definitely not in its current state :) ).