Bug 37265

Summary:

IDB callbacks should fire asynchronously

Product:

WebKit

Reporter:

Jeremy Orlow <jorlow>

Component:

New Bugs

Assignee:

Jeremy Orlow <jorlow>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, gustavo, japhet, pfeldman, webkit-ews, webkit.review.bot, xan.lopez, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	yurys: review+

Jeremy Orlow

Reported 2010-04-08 06:24:41 PDT

IDB callbacks should fire asynchronously

Attachments
Patch (4.81 KB, patch) 2010-04-08 06:37 PDT, Jeremy Orlow	yurys: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jeremy Orlow

Comment 1 2010-04-08 06:37:57 PDT

Created attachment 52856 [details] Patch

Jeremy Orlow

Comment 2 2010-04-08 06:39:44 PDT

In addition to being the right thing to do, this exposes the bug we've been working on in --single-process mode within Chromium.

Eric Seidel (no email)

Comment 3 2010-04-08 06:40:05 PDT

Attachment 52856 [details] did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/1674139

Early Warning System Bot

Comment 4 2010-04-08 06:45:48 PDT

Attachment 52856 [details] did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/1660252

WebKit Review Bot

Comment 5 2010-04-08 06:48:48 PDT

Attachment 52856 [details] did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/1612322

Jeremy Orlow

Comment 6 2010-04-08 06:49:05 PDT

Oops...will upload a new version that doesn't break everything in a sec. Pavel/Yury: Note that this patch also makes the inspector bug I was seeing show up in single process mode. Still don't know if the bug is related to my code (or why it's not working correctly) or whether it's a bug in inspector.

Yury Semikhatsky

Comment 7 2010-04-08 06:59:13 PDT

Please fix linux and mac bot failures, otherwise r+.

Jeremy Orlow

Comment 8 2010-04-08 07:14:57 PDT

Committed r57275: <http://trac.webkit.org/changeset/57275>

WebKit Review Bot

Comment 9 2010-04-08 07:53:48 PDT

http://trac.webkit.org/changeset/57275 might have broken Leopard Intel Release (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/57273 http://trac.webkit.org/changeset/57275

Adam Barth

Comment 10 2010-04-08 07:56:44 PDT

The real failure is http://trac.webkit.org/changeset/57274. tkent is on it.

Note You need to log in before you can comment on or make changes to this bug.