Bug 37251

Summary: Rename target to configuration in new-run-webkit-tests to match the rest of WebKit
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, eric, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch eric: review+

Adam Barth
Reported 2010-04-08 00:22:48 PDT
Rename target to configuration in new-run-webkit-tests to match the rest of WebKit
Attachments
Patch (27.21 KB, patch)
2010-04-08 00:23 PDT, Adam Barth 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-04-08 00:23:43 PDT
Created attachment 52843 [details] Patch
Eric Seidel (no email)
Comment 2 2010-04-08 00:27:32 PDT
Comment on attachment 52843 [details] Patch Wow, some of this code hurts. + optparser.add_option('--release', action='store_const', const='Release', + dest="configuration", help='Set the configuration to Debug') should say Release. otherwise r=me.
Adam Barth
Comment 3 2010-04-08 00:28:10 PDT
Committed r57256: <http://trac.webkit.org/changeset/57256>
Eric Seidel (no email)
Comment 4 2010-04-08 00:29:42 PDT
CCing Ojan in case this breaks stuff for the gardner tomrorow.
Adam Barth
Comment 5 2010-04-08 00:50:00 PDT
Added --target back in http://trac.webkit.org/changeset/57258 to fix the downstream bots. We should change them to use --debug or --release and then remove this evil option.
Dirk Pranke
Comment 6 2010-04-08 12:11:57 PDT
LGTM apart from the thing you already broke and fixed ;)
Note You need to log in before you can comment on or make changes to this bug.