Summary: | Rename target to configuration in new-run-webkit-tests to match the rest of WebKit | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dpranke, eric, ojan | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Adam Barth
2010-04-08 00:22:48 PDT
Created attachment 52843 [details]
Patch
Comment on attachment 52843 [details]
Patch
Wow, some of this code hurts.
+ optparser.add_option('--release', action='store_const', const='Release',
+ dest="configuration", help='Set the configuration to Debug')
should say Release. otherwise r=me.
Committed r57256: <http://trac.webkit.org/changeset/57256> CCing Ojan in case this breaks stuff for the gardner tomrorow. Added --target back in http://trac.webkit.org/changeset/57258 to fix the downstream bots. We should change them to use --debug or --release and then remove this evil option. LGTM apart from the thing you already broke and fixed ;) |