Bug 37243

Summary:

[chromium] <select> dropdowns don't die when an item is selected

Product:

WebKit

Reporter:

Evan Stade <estade>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Critical

CC:

eric, jcivelli

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Attachments:

Description	Flags
try1	none
stylefix	commit-queue: commit-queue-

Evan Stade

Reported 2010-04-07 17:49:25 PDT

see http://code.google.com/p/chromium/issues/detail?id=40749 and http://code.google.com/p/chromium/issues/detail?id=40556

Attachments
try1 (2.06 KB, patch) 2010-04-07 17:52 PDT, Evan Stade	no flags	Details Formatted Diff Diff
stylefix (2.06 KB, patch) 2010-04-07 17:57 PDT, Evan Stade	commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Evan Stade

Comment 1 2010-04-07 17:52:23 PDT

Created attachment 52813 [details] try1

Evan Stade

Comment 2 2010-04-07 17:55:53 PDT

this is p1 in the chromium tracker, so I'm marking importance as P1/critical. Hopefully that's the right thing to do.

Evan Stade

Comment 3 2010-04-07 17:57:35 PDT

Created attachment 52815 [details] stylefix

Dimitri Glazkov (Google)

Comment 4 2010-04-08 12:47:39 PDT

Comment on attachment 52815 [details] stylefix r=me. Can we please add more testing around popups? We're in bad place here.

WebKit Commit Bot

Comment 5 2010-04-09 02:48:08 PDT

Comment on attachment 52815 [details] stylefix Clearing flags on attachment: 52815 Committed r57321: <http://trac.webkit.org/changeset/57321>

WebKit Commit Bot

Comment 6 2010-04-09 02:56:45 PDT

Comment on attachment 52815 [details] stylefix Rejecting patch 52815 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--force']" exit_code: 1 patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/platform/chromium/PopupMenuChromium.cpp Hunk #1 FAILED at 412. Hunk #2 FAILED at 1127. 2 out of 2 hunks FAILED -- saving rejects to file WebCore/platform/chromium/PopupMenuChromium.cpp.rej patching file WebCore/platform/chromium/PopupMenuChromium.h Hunk #1 succeeded at 154 with fuzz 2 (offset 3 lines). Full output: http://webkit-commit-queue.appspot.com/results/1580336

Note You need to log in before you can comment on or make changes to this bug.