Bug 37238

Summary:

rebaseline-chromium-webkit-tests should be able to run from a webkit-only checkout

Product:

WebKit

Reporter:

Dirk Pranke <dpranke>

Component:

Tools / Tests

Assignee:

Dirk Pranke <dpranke>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, cjerdonek, dglazkov, eric, ojan, victorw, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none
fix dangling reference to port instead of target_port, fix typo	none
use copy.copy() to clone the options object	abarth: review+

Dirk Pranke

Reported 2010-04-07 15:53:49 PDT

Currently rebaseline-chromium-webkit-tests requires the user to be running from a chromium checkout that includes webkit. It would be easier for webkit gardeners and other maintainers to be able to rebaseline ports using a webkit-only checkout. The script currently requires a Chromium checkout for two reasons: 1) It needs to be able to check for the existence of an image_diff() binary (this method is currently only exported by the chromium ports) 2) It needs to be able to determine some basic configuration info for the platform it is trying to rebaseline (location of the test_expectations file, layout test dirs, list of test platform names, etc). The current code distinguishes the port it is running on (e.g., "chromium-mac") from the port it is rebaselining (e.g., "chromium-win". It gets the config information from the first ("running") port and the baseline paths, etc. from the second ("rebaselining"). To make this really work, we need a third port object, which we'll call the "target" port. The script will use the "running" port to invoke the image diff executable and to shell out to make directories and do other platform-specific things. It'll use the "target" port for the configuration info mentioned above, and continue to use the rebaselining port the way it does now.

Attachments
Patch (10.35 KB, patch) 2010-04-07 15:59 PDT, Dirk Pranke	no flags	Details Formatted Diff Diff
Patch (10.91 KB, patch) 2010-04-07 16:35 PDT, Dirk Pranke	no flags	Details Formatted Diff Diff
fix dangling reference to port instead of target_port, fix typo (11.38 KB, patch) 2010-04-07 16:42 PDT, Dirk Pranke	no flags	Details Formatted Diff Diff
use copy.copy() to clone the options object (11.31 KB, patch) 2010-04-07 16:51 PDT, Dirk Pranke	abarth: review+	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Dirk Pranke

Comment 1 2010-04-07 15:59:27 PDT

Created attachment 52796 [details] Patch

Dirk Pranke

Comment 2 2010-04-07 16:35:11 PDT

Created attachment 52802 [details] Patch

Dirk Pranke

Comment 3 2010-04-07 16:42:29 PDT

Created attachment 52803 [details] fix dangling reference to port instead of target_port, fix typo

Dirk Pranke

Comment 4 2010-04-07 16:51:29 PDT

Created attachment 52807 [details] use copy.copy() to clone the options object

Victor Wang

Comment 5 2010-04-07 17:43:44 PDT

LGTM.

Adam Barth

Comment 6 2010-04-07 21:50:57 PDT

Comment on attachment 52807 [details] use copy.copy() to clone the options object I'm relying on victorw here because he wrote this code. Looks reasonable to me though.

Dirk Pranke

Comment 7 2010-04-08 13:47:42 PDT

Committed r57290: <http://trac.webkit.org/changeset/57290>

WebKit Review Bot

Comment 8 2010-04-08 14:22:14 PDT

http://trac.webkit.org/changeset/57290 might have broken SnowLeopard Intel Release (Tests)

Note You need to log in before you can comment on or make changes to this bug.