Bug 37233

Summary: add slightly better logging to the python websocket_server wrapper script
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: Tools / TestsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cjerdonek, eric, ukai
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch to add --verbose to websocket_server, slightly improve logging
none
Patch none

Dirk Pranke
Reported 2010-04-07 14:37:55 PDT
It can be hard to debug what's going on with the python websocket server; I recently spent a few misdirected hours debugging issues because I didn't realize that there was an old websocket server already running on my machine. This change adds a --verbose flag for debug output and fixes a couple other minor nits.
Attachments
patch to add --verbose to websocket_server, slightly improve logging (1.96 KB, patch)
2010-04-07 14:43 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Patch (2.48 KB, patch)
2010-04-19 14:36 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2010-04-07 14:43:54 PDT
Created attachment 52784 [details] patch to add --verbose to websocket_server, slightly improve logging
Fumitoshi Ukai
Comment 2 2010-04-07 18:17:05 PDT
(In reply to comment #1) > Created an attachment (id=52784) [details] > patch to add --verbose to websocket_server, slightly improve logging LGTM
Alexey Proskuryakov
Comment 3 2010-04-07 20:58:42 PDT
How does one pass this flag? I only know run-webkit-websocketserver, which doesn't seem to forward any flags.
Dirk Pranke
Comment 4 2010-04-08 12:17:36 PDT
(In reply to comment #3) > How does one pass this flag? I only know run-webkit-websocketserver, which > doesn't seem to forward any flags. There isn't a generic new-run-webkit-websocketserver wrapper that would invoke this python code. We should probably add one. Otherwise, you would only pass this flag if you were running the script directly by hand.
Eric Seidel (no email)
Comment 5 2010-04-09 14:11:50 PDT
Comment on attachment 52784 [details] patch to add --verbose to websocket_server, slightly improve logging 241 pid = None looks unrelated.
Dirk Pranke
Comment 6 2010-04-09 15:28:06 PDT
(In reply to comment #5) > (From update of attachment 52784 [details]) > 241 pid = None > looks unrelated. Yes, it is unrelated, but it is one of the "other minor nits" referred to in my first comment.
Eric Seidel (no email)
Comment 7 2010-04-19 00:11:40 PDT
Comment on attachment 52784 [details] patch to add --verbose to websocket_server, slightly improve logging OK.
Dirk Pranke
Comment 8 2010-04-19 14:36:47 PDT
Created attachment 53722 [details] Patch
Eric Seidel (no email)
Comment 9 2010-04-19 14:56:40 PDT
Comment on attachment 53722 [details] Patch OK.
Dirk Pranke
Comment 10 2010-04-19 14:59:50 PDT
Comment on attachment 53722 [details] Patch Clearing flags on attachment: 53722 Committed r57845: <http://trac.webkit.org/changeset/57845>
Dirk Pranke
Comment 11 2010-04-19 14:59:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.