| Summary: | add slightly better logging to the python websocket_server wrapper script | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||||
| Component: | Tools / Tests | Assignee: | Dirk Pranke <dpranke> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ap, cjerdonek, eric, ukai | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Dirk Pranke
2010-04-07 14:37:55 PDT
Created attachment 52784 [details]
patch to add --verbose to websocket_server, slightly improve logging
(In reply to comment #1) > Created an attachment (id=52784) [details] > patch to add --verbose to websocket_server, slightly improve logging LGTM How does one pass this flag? I only know run-webkit-websocketserver, which doesn't seem to forward any flags. (In reply to comment #3) > How does one pass this flag? I only know run-webkit-websocketserver, which > doesn't seem to forward any flags. There isn't a generic new-run-webkit-websocketserver wrapper that would invoke this python code. We should probably add one. Otherwise, you would only pass this flag if you were running the script directly by hand. Comment on attachment 52784 [details]
patch to add --verbose to websocket_server, slightly improve logging
241 pid = None
looks unrelated.
(In reply to comment #5) > (From update of attachment 52784 [details]) > 241 pid = None > looks unrelated. Yes, it is unrelated, but it is one of the "other minor nits" referred to in my first comment. Comment on attachment 52784 [details]
patch to add --verbose to websocket_server, slightly improve logging
OK.
Created attachment 53722 [details]
Patch
Comment on attachment 53722 [details]
Patch
OK.
Comment on attachment 53722 [details] Patch Clearing flags on attachment: 53722 Committed r57845: <http://trac.webkit.org/changeset/57845> All reviewed patches have been landed. Closing bug. |