Bug 37226

Summary: [Qt] Remove shaderSource manipulation from GraphicsContext3DQt.cpp
Product: WebKit Reporter: Jarkko Sakkinen <jarkko.j.sakkinen>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: CLOSED FIXED    
Severity: Normal CC: commit-queue, hausmann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on:    
Bug Blocks: 35784    
Attachments:
Description Flags
Removes appending of precision and version from shaderSource none

Description Jarkko Sakkinen 2010-04-07 11:57:14 PDT
Remove ugly hack from GraphicsContext3D::shadeSource implementation that appends #version to shaderSource. This is all wrong and mistake by me when I first did it and it breaks lot of WebGL pages. Making sure that shader source meets WebGL specification must be handled in platform independent WebGL code.
Comment 1 Jarkko Sakkinen 2010-04-07 12:45:09 PDT
Created attachment 52771 [details]
Removes appending of precision and version from shaderSource
Comment 2 WebKit Commit Bot 2010-04-08 02:23:07 PDT
Comment on attachment 52771 [details]
Removes appending of precision and version from shaderSource

Clearing flags on attachment: 52771

Committed r57267: <http://trac.webkit.org/changeset/57267>
Comment 3 WebKit Commit Bot 2010-04-08 02:23:11 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Simon Hausmann 2010-04-08 03:40:15 PDT
Revision r57267 cherry-picked into qtwebkit-2.0 with commit 26ec2a2b5376ffc5810a52d5476d51ca9b860a36