Bug 37199

Summary: [WINCE] Add missing headers
Product: WebKit Reporter: Young Han Lee <joybro201>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, skyul, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch
none
Now with style issue fixed none

Young Han Lee
Reported 2010-04-07 03:26:03 PDT
Include necessary headers. They are omitted because the build system used precompiled header.
Attachments
Patch (3.53 KB, patch)
2010-04-07 03:29 PDT, Young Han Lee 		no flags
DetailsFormatted DiffDiff
Now with style issue fixed (3.55 KB, patch)
2010-04-07 05:37 PDT, Young Han Lee 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Young Han Lee
Comment 1 2010-04-07 03:29:06 PDT
Created attachment 52722 [details] Patch
WebKit Review Bot
Comment 2 2010-04-07 03:36:32 PDT
Attachment 52722 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/platform/graphics/wince/FontCustomPlatformData.cpp:29: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Young Han Lee
Comment 3 2010-04-07 05:37:24 PDT
Created attachment 52731 [details] Now with style issue fixed
WebKit Commit Bot
Comment 4 2010-04-08 07:05:22 PDT
Comment on attachment 52731 [details] Now with style issue fixed Clearing flags on attachment: 52731 Committed r57273: <http://trac.webkit.org/changeset/57273>
WebKit Commit Bot
Comment 5 2010-04-08 07:05:26 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2010-04-08 07:53:37 PDT
http://trac.webkit.org/changeset/57273 might have broken Leopard Intel Release (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/57273 http://trac.webkit.org/changeset/57275
Adam Barth
Comment 7 2010-04-08 07:56:17 PDT
The failure is really http://trac.webkit.org/changeset/57274. tkent is on it.
Note You need to log in before you can comment on or make changes to this bug.