[Qt] Interrupting JavaScript is cumbersome when you use QtLaucher for testing or profiling.

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Balazs Kelemen]

Since we often use QtLauncher as a testing tool I think it would be better to turn off the shouldInterruptJavaScript feature in the launcher's WebPage.

[Balazs Kelemen]

Created attachment 52723 [details]
proposed patch

This also fix the feature to start loading multiply url-s in different windows at startup.

[Balazs Kelemen]

Created attachment 52725 [details]
fix a mistyping

[Simon Hausmann]

No general objection from me, but why not automatically return true when in robot mode instead of requiring another commandline option?

Another idea would be to add a GUI option. On Symbian commandline options are not feasible ;(

[Balazs Kelemen]

Created attachment 52867 [details]
GUI option instead of command line argument

[Simon Hausmann]

Comment on attachment 52867 [details]
GUI option instead of command line argument

r+, but I think you can remove

+    WebPage(QObject* parent = 0, bool interruptingJavaScriptEnabled = false);

as you don't seem to call the constructor with that argument.

I'm generally not a fan of boolean arguments that make the caller code harder to read,

[Balazs Kelemen]

Created attachment 53802 [details]
proposed patch

No boolean arguments :)

[WebKit Commit Bot]

Comment on attachment 53802 [details]
proposed patch

Clearing flags on attachment: 53802

Committed r57974: <http://trac.webkit.org/changeset/57974>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.