Bug 37198

Summary: [Qt] Interrupting JavaScript is cumbersome when you use QtLaucher for testing or profiling.
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hausmann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch
none
fix a mistyping
none
GUI option instead of command line argument
hausmann: review+
proposed patch none

Balazs Kelemen
Reported 2010-04-07 03:25:55 PDT
Since we often use QtLauncher as a testing tool I think it would be better to turn off the shouldInterruptJavaScript feature in the launcher's WebPage.
Attachments
proposed patch (6.28 KB, patch)
2010-04-07 03:33 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
fix a mistyping (6.29 KB, patch)
2010-04-07 03:38 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
GUI option instead of command line argument (5.67 KB, patch)
2010-04-08 08:09 PDT, Balazs Kelemen 		hausmann: review+
DetailsFormatted DiffDiff
proposed patch (5.13 KB, patch)
2010-04-20 05:39 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Balazs Kelemen
Comment 1 2010-04-07 03:33:32 PDT
Created attachment 52723 [details] proposed patch This also fix the feature to start loading multiply url-s in different windows at startup.
Balazs Kelemen
Comment 2 2010-04-07 03:38:07 PDT
Created attachment 52725 [details] fix a mistyping
Simon Hausmann
Comment 3 2010-04-08 06:58:08 PDT
No general objection from me, but why not automatically return true when in robot mode instead of requiring another commandline option? Another idea would be to add a GUI option. On Symbian commandline options are not feasible ;(
Balazs Kelemen
Comment 4 2010-04-08 08:09:00 PDT
Created attachment 52867 [details] GUI option instead of command line argument
Simon Hausmann
Comment 5 2010-04-19 17:40:15 PDT
Comment on attachment 52867 [details] GUI option instead of command line argument r+, but I think you can remove + WebPage(QObject* parent = 0, bool interruptingJavaScriptEnabled = false); as you don't seem to call the constructor with that argument. I'm generally not a fan of boolean arguments that make the caller code harder to read,
Balazs Kelemen
Comment 6 2010-04-20 05:39:48 PDT
Created attachment 53802 [details] proposed patch No boolean arguments :)
WebKit Commit Bot
Comment 7 2010-04-21 06:33:04 PDT
Comment on attachment 53802 [details] proposed patch Clearing flags on attachment: 53802 Committed r57974: <http://trac.webkit.org/changeset/57974>
WebKit Commit Bot
Comment 8 2010-04-21 06:33:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.