Summary: | [chromium] implement getData('text/html') for paste and drop events | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tony Chang <tony> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, eric, jianli, oliver | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Tony Chang
2010-04-07 01:45:38 PDT
Created attachment 52713 [details]
Patch
The webkit mac side is here: https://bugs.webkit.org/show_bug.cgi?id=19893 I can try to make this work in safari win too (seems straightforward). Bug https://bugs.webkit.org/show_bug.cgi?id=37193 is related, but it's for general types (and would involve some IPC plumbing to allow arbitrary types through). Comment on attachment 52713 [details]
Patch
Looks reasonable to me.
CCing Oliver (who has worked on mac DnD) so he sees this go by. Comment on attachment 52713 [details]
Patch
Watching the landing since I'm not sure if it'll pass or fail on QT.
Comment on attachment 52713 [details] Patch Rejecting patch 52713 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Eric Seidel', '--force']" exit_code: 1 Last 500 characters of output: -html.html patching file LayoutTests/platform/gtk/Skipped patching file LayoutTests/platform/mac/Skipped Hunk #1 FAILED at 151. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/Skipped.rej patching file LayoutTests/platform/win/Skipped Hunk #1 FAILED at 822. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/win/Skipped.rej patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/platform/chromium/ClipboardChromium.cpp Full output: http://webkit-commit-queue.appspot.com/results/1610409 Committed r57464: <http://trac.webkit.org/changeset/57464> |