Bug 37160

Summary:

[V8] Throw exception in SerializedScriptValue on input errors

Product:

WebKit

Reporter:

Vitaly Repeshko <vitalyr>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch v1	yurys: review+

Description Vitaly Repeshko 2010-04-06 10:43:25 PDT

[V8] Throw exception in SerializedScriptValue on input errors

Comment 1 Vitaly Repeshko 2010-04-06 10:48:51 PDT

Created attachment 52650 [details]
patch v1

Comment 2 Yury Semikhatsky 2010-04-07 00:08:01 PDT

Comment on attachment 52650 [details]
patch v1

> -    explicit SerializedScriptValue(v8::Handle<v8::Value>);
> +    SerializedScriptValue(v8::Handle<v8::Value>, bool& didThrow);
> 
I don't like the idea of out parameter in the constructor but since it's private I think that is ok.

Comment 3 Vitaly Repeshko 2010-04-07 07:05:32 PDT

	M	WebCore/ChangeLog
	M	WebCore/bindings/scripts/CodeGeneratorV8.pm
	M	WebCore/bindings/v8/SerializedScriptValue.cpp
	M	WebCore/bindings/v8/SerializedScriptValue.h
	M	WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp
	M	WebCore/bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp
	M	WebCore/bindings/v8/custom/V8HistoryCustom.cpp
	M	WebCore/bindings/v8/custom/V8MessagePortCustom.cpp
	M	WebCore/bindings/v8/custom/V8PopStateEventCustom.cpp
	M	WebCore/bindings/v8/custom/V8WorkerCustom.cpp
Committed r57207