Bug 37157
| Summary: | REGRESSION (r57109): editing/pasteboard/drag-image-to-contenteditable-in-iframe.html fails on Windows | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> |
| Component: | HTML Editing | Assignee: | Darin Adler <darin> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | darin, sam |
| Priority: | P2 | Keywords: | InRadar, LayoutTestFailure, PlatformOnly |
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| URL: | http://build.webkit.org/results/Windows%20Release%20(Tests)/r57109%20(10957)/editing/pasteboard/drag-image-to-contenteditable-in-iframe-pretty-diff.html | ||
| Bug Depends on: | |||
| Bug Blocks: | 37284 | ||
Adam Roben (:aroben)
Since new results were landed in r57109, editing/pasteboard/drag-image-to-contenteditable-in-iframe.html has been failing on Windows.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adam Roben (:aroben)
<rdar://problem/7832412>
Darin Adler
I need the help from someone with a Windows machine who can regenerate the results of this test.
Adam Roben (:aroben)
(In reply to comment #2)
> I need the help from someone with a Windows machine who can regenerate the
> results of this test.
Darin, it looks to me like the Windows bots are generating the same results that the Mac bots generated prior to r57109. i.e., the results coming out of the Windows bots are identical to the expected results from r57108. Does this indicate that the bug is not fixed on Windows?
Darin Adler
Alexey says I can just get the results from the bots. I will do that now.
Darin Adler
(In reply to comment #3)
> Darin, it looks to me like the Windows bots are generating the same results
> that the Mac bots generated prior to r57109. i.e., the results coming out of
> the Windows bots are identical to the expected results from r57108. Does this
> indicate that the bug is not fixed on Windows?
That would be exceedingly surprising. There is no platform-specific element involved here. I am not sure how to figure it out.
Darin Adler
(In reply to comment #5)
> (In reply to comment #3)
> > Darin, it looks to me like the Windows bots are generating the same results
> > that the Mac bots generated prior to r57109. i.e., the results coming out of
> > the Windows bots are identical to the expected results from r57108. Does this
> > indicate that the bug is not fixed on Windows?
>
> That would be exceedingly surprising. There is no platform-specific element
> involved here. I am not sure how to figure it out.
But I see that you are correct. This is a mystery.
Darin Adler
I have now checked and the bug that r57109 is indeed fixed on Windows as well as Mac.
But this dragging test works differently because of a difference in the code path on Windows. On Windows, the new <img> element has a full path to the image. On Mac, the new <img> element has the same src attribute as the original <img> element.
So it's not surprising that this test has different results, and it has nothing to do with the bug I fixed, but it does represent a platform difference.
Darin Adler
http://trac.webkit.org/changeset/57160
Darin Adler
I filed bug 37162 about the problem.