Bug 37150

Summary:

[V8][Android] PageCache crashes when JavaScript is disabled

Product:

WebKit

Reporter:

Andrei Popescu <andreip>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, android-webkit-unforking, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Android

OS:

Android

Attachments:

Description	Flags
Check the context to avoid crashing when it's null.	none

Andrei Popescu

Reported 2010-04-06 06:58:54 PDT

WebKit's Page Cache mechanism always attempts to save the script state, regardless of whether JavaScript is enabled or not in the browser. When JS is disabled, a frame's JS execution context is null. However, the Android V8 bindings always expect it to be non-null. The saving and restoration of the script state should be a no-op when JS is disabled. Patch coming.

Attachments
Check the context to avoid crashing when it's null. (2.11 KB, patch) 2010-04-06 07:04 PDT, Andrei Popescu	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Andrei Popescu

Comment 1 2010-04-06 07:04:25 PDT

Created attachment 52633 [details] Check the context to avoid crashing when it's null.

Dimitri Glazkov (Google)

Comment 2 2010-04-06 08:31:08 PDT

Comment on attachment 52633 [details] Check the context to avoid crashing when it's null. ok.

WebKit Commit Bot

Comment 3 2010-04-06 10:49:41 PDT

Comment on attachment 52633 [details] Check the context to avoid crashing when it's null. Clearing flags on attachment: 52633 Committed r57157: <http://trac.webkit.org/changeset/57157>

WebKit Commit Bot

Comment 4 2010-04-06 10:49:48 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.