Bug 37149

Summary: JS code generator does not support feature conditional attributes that are writable
Product: WebKit Reporter: Simon Hausmann <hausmann>
Component: Tools / TestsAssignee: Simon Hausmann <hausmann>
Status: CLOSED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, laszlo.gombos, webkit.review.bot
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 36750    
Attachments:
Description Flags
Patch none

Simon Hausmann
Reported 2010-04-06 06:44:27 PDT
When using the conditional keyword for attributes that can be written, then the generated code is missing the feature #ifdefs for the setter functions. The getter functions do have the correct #ifdefs in place. For example: attribute [Conditional=TOUCH_EVENTS] EventListener ontouchstart;
Attachments
Patch (2.20 KB, patch)
2010-04-06 06:55 PDT, Simon Hausmann 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Hausmann
Comment 1 2010-04-06 06:55:27 PDT
Created attachment 52631 [details] Patch
WebKit Commit Bot
Comment 2 2010-04-06 12:51:06 PDT
Comment on attachment 52631 [details] Patch Clearing flags on attachment: 52631 Committed r57163: <http://trac.webkit.org/changeset/57163>
WebKit Commit Bot
Comment 3 2010-04-06 12:51:11 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 4 2010-04-06 13:54:00 PDT
http://trac.webkit.org/changeset/57163 might have broken Tiger Intel Release
Adam Barth
Comment 5 2010-04-06 13:56:17 PDT
Sorry for the noise. You're running into https://bugs.webkit.org/show_bug.cgi?id=37145.
Simon Hausmann
Comment 6 2010-04-07 00:48:37 PDT
Revision r57163 cherry-picked into qtwebkit-2.0 with commit 6dcb7f961c5941963b288f5fc4ef3c64877f62ae
Note You need to log in before you can comment on or make changes to this bug.