Bug 37121

Summary: REGRESSION(r57081): We think it triggered two tests to fail on Tiger because of race conditions (Requested by abarth on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: abarth, darin, dglazkov, eric, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 36864    
Description Flags
ROLLOUT of r57081 none

Description WebKit Review Bot 2010-04-05 15:51:21 PDT
http://trac.webkit.org/changeset/57081 broke the build:
We think it triggered two tests to fail on Tiger because of race conditions (Requested by abarth on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2010-04-05 15:51:40 PDT
Created attachment 52584 [details]
ROLLOUT of r57081
Comment 2 Adam Barth 2010-04-05 16:07:39 PDT
Comment on attachment 52584 [details]
ROLLOUT of r57081

Clearing flags on attachment: 52584

Committed r57100: <http://trac.webkit.org/changeset/57100>
Comment 3 Adam Barth 2010-04-05 16:07:45 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Eric Seidel (no email) 2010-04-05 16:10:10 PDT
This also affected Qt.  Ossy reproduced the failure locally and confirmed that the rollout caused the failure to go away.

I've not yet been able to reproduce the failure on Leopard.  I don't have access to a Tiger machine.
Comment 5 Eric Seidel (no email) 2010-04-05 16:11:35 PDT
Our understanding of this failure is that this regression made it possible for load events to fire on the outermost document, before the inner <object> elements had a chance to schedule their loads.

<object> load scheduling is crazy.  it happens in the renderers via  updateWidget which is scheduled from attach().
Comment 6 Eric Seidel (no email) 2010-04-05 16:30:07 PDT
Looks like this rollout fixed both the Qt bot and Tiger.