Bug 37116

Summary: [chromium] Rename graphics layer specific classes from *Skia to *Chromium
Product: WebKit Reporter: Vangelis Kokkevis <vangelis>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, dglazkov, eric, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch
none
Fixing first webkit style issue. none

Vangelis Kokkevis
Reported 2010-04-05 15:21:39 PDT
The renaming of classes is done in preparation for moving the code from platform/graphics/skia to platform/graphics/chromium as the layer compositor code will be very similar across all platforms, whether we're using Skia or CG. The classes affected are: LayerSkia -> LayerChromium LayerRendererSkia -> LayerRendererChromium GraphicsLayerSkia -> GraphicsLayerChromium
Attachments
Proposed patch (50.59 KB, patch)
2010-04-05 17:47 PDT, Vangelis Kokkevis 		no flags
DetailsFormatted DiffDiff
Fixing first webkit style issue. (50.57 KB, patch)
2010-04-05 18:21 PDT, Vangelis Kokkevis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Vangelis Kokkevis
Comment 1 2010-04-05 17:47:21 PDT
Created attachment 52591 [details] Proposed patch
WebKit Review Bot
Comment 2 2010-04-05 17:52:37 PDT
Attachment 52591 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/platform/graphics/skia/LayerRendererSkia.h:38: Alphabetical sorting problem. [build/include_order] [4] WebCore/platform/graphics/skia/LayerSkia.h:72: More than one command on the same line [whitespace/newline] [4] WebCore/platform/graphics/skia/LayerSkia.h:125: More than one command on the same line [whitespace/newline] [4] Total errors found: 3 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Vangelis Kokkevis
Comment 3 2010-04-05 18:21:54 PDT
Created attachment 52593 [details] Fixing first webkit style issue. I've been previously told that the "More than one command on the same line" warnings are a result of a bug in the style checker so I'm not modifying those lines.
WebKit Review Bot
Comment 4 2010-04-05 18:26:14 PDT
Attachment 52593 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/platform/graphics/skia/LayerSkia.h:72: More than one command on the same line [whitespace/newline] [4] WebCore/platform/graphics/skia/LayerSkia.h:125: More than one command on the same line [whitespace/newline] [4] Total errors found: 2 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Dimitri Glazkov (Google)
Comment 5 2010-04-06 08:40:56 PDT
Comment on attachment 52593 [details] Fixing first webkit style issue. looks great!
WebKit Commit Bot
Comment 6 2010-04-06 16:17:08 PDT
Comment on attachment 52593 [details] Fixing first webkit style issue. Clearing flags on attachment: 52593 Committed r57176: <http://trac.webkit.org/changeset/57176>
WebKit Commit Bot
Comment 7 2010-04-06 16:17:13 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 8 2010-04-06 16:47:11 PDT
http://trac.webkit.org/changeset/57176 might have broken SnowLeopard Intel Release (Tests)
Note You need to log in before you can comment on or make changes to this bug.