Summary: | [chromium] Rename graphics layer specific classes from *Skia to *Chromium | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Vangelis Kokkevis <vangelis> | ||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, commit-queue, dglazkov, eric, levin, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Vangelis Kokkevis
2010-04-05 15:21:39 PDT
Created attachment 52591 [details]
Proposed patch
Attachment 52591 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/graphics/skia/LayerRendererSkia.h:38: Alphabetical sorting problem. [build/include_order] [4]
WebCore/platform/graphics/skia/LayerSkia.h:72: More than one command on the same line [whitespace/newline] [4]
WebCore/platform/graphics/skia/LayerSkia.h:125: More than one command on the same line [whitespace/newline] [4]
Total errors found: 3 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 52593 [details]
Fixing first webkit style issue.
I've been previously told that the "More than one command on the same line" warnings are a result of a bug in the style checker so I'm not modifying those lines.
Attachment 52593 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/graphics/skia/LayerSkia.h:72: More than one command on the same line [whitespace/newline] [4]
WebCore/platform/graphics/skia/LayerSkia.h:125: More than one command on the same line [whitespace/newline] [4]
Total errors found: 2 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 52593 [details]
Fixing first webkit style issue.
looks great!
Comment on attachment 52593 [details] Fixing first webkit style issue. Clearing flags on attachment: 52593 Committed r57176: <http://trac.webkit.org/changeset/57176> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/57176 might have broken SnowLeopard Intel Release (Tests) |