Bug 3711 – Displayed PDF have limited options in contextual menu

• Component: WebKit API
• Status: VERIFIED FIXED

[Hanspeter Schaub]

When viewing PDF in the latest builds (6/25/05), there are only very few options available in the 
contextual menu.  In particular, the "View in Preview" option has been removed?  I'm running Safari 2.0 
with the lastest nightly webkit build.

[Chris Petersen]

Confirming this issue with TOT Webkit (6/26). The contextual menu that is normally used for viewing PDF 
is not displayed. I get a generic contextual menu that contains Back, Reload, Save Page as, and Print Page.

[Chris Petersen]

John:

Can you confirm this on TOT ?

[John Sullivan]

When I changed WebKit to use the standard context menu delegate mechanism for the PDF context menu, 
this changed what appears in the context menu for Safari. The next Safari release will take advantage of 
this change in the way the PDF context menu works, but the current Safari release ends up not showing 
the PDF-specific items.

Darin, do you think we need to do something about this? I can imagine some hideous hack where WebKit 
somehow determines that it is running under Safari and that Safari isn't putting the PDF-specific items 
into the context menu, and forcing them in somehow. I'd rather not implement such a hack though.

[Darin Adler]

I don't think a Safari-specific hack is a great idea, but if there's anything we can do to help the old Safari 
do the right thing that might also help other applications, that would be great.

Also, there's going to be a long time where WebKit developers outside Apple are going to be using that 
old Safari with new WebKit, so if there's something straightforward we can do, we should, even if we 
ultimately don't ship it. If necessary we could even add a preprocessor define that generates a WebKit for 
better compatibility with old Safari.

[John Sullivan]

Created attachment 2738 [details]
patch to always include PDF items for older executables

[Darin Adler]

Comment on attachment 2738 [details]
patch to always include PDF items for older executables

Looks cool, r=me.

[John Sullivan]

I found a non-Safari-specific solution that isn't *too* hacky. Hanspeter, please verify that this works for 
you.

[Hanspeter Schaub]

Seems to work find in the "old" version of Safari in Tiger.  I see the previous contextual menu added after 
the default items.

(In reply to comment #7)
> I found a non-Safari-specific solution that isn't *too* hacky. Hanspeter, please verify that this works for 
> you.

[John Sullivan]

Since the originator has agreed that the problem is fixed, I'm changing this to VERIFIED.