| Summary: | Turns out commit_info.committer() can be None | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
| Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, commit-queue, eric, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Adam Barth
2010-04-05 12:45:31 PDT
Created attachment 52558 [details]
Patch
Comment on attachment 52558 [details]
Patch
OK.
Comment on attachment 52558 [details] Patch Rejecting patch 52558 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Eric Seidel', '--force']" exit_code: 1 Last 500 characters of output: itTools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebKitTools/Scripts/webkitpy/common/checkout/commitinfo.py patching file WebKitTools/Scripts/webkitpy/tool/bot/sheriff.py Hunk #1 succeeded at 87 with fuzz 2. patching file WebKitTools/Scripts/webkitpy/tool/bot/sheriff_unittest.py Hunk #1 FAILED at 68. 1 out of 1 hunk FAILED -- saving rejects to file WebKitTools/Scripts/webkitpy/tool/bot/sheriff_unittest.py.rej patching file WebKitTools/Scripts/webkitpy/tool/commands/queries.py Full output: http://webkit-commit-queue.appspot.com/results/1533270 http://trac.webkit.org/changeset/57132 might have broken Tiger Intel Release Attachment 52558 [details] was posted by a committer and has review+, assigning to Adam Barth for commit.
|