Bug 37103

Summary: assorted helper functions and cleanup of git utilities
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 36394    
Attachments:
Description Flags
Patch eric: review+

Ojan Vafai
Reported 2010-04-05 11:57:26 PDT
assorted helper functions and cleanup of git utilities
Attachments
Patch (13.61 KB, patch)
2010-04-05 12:01 PDT, Ojan Vafai 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2010-04-05 12:01:49 PDT
Created attachment 52551 [details] Patch
WebKit Review Bot
Comment 2 2010-04-05 12:04:03 PDT
Attachment 52551 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKitTools/Scripts/webkitpy/common/checkout/scm.py:211: deprecated form of raising exception [pep8/W602] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ojan Vafai
Comment 3 2010-04-05 12:06:11 PDT
(In reply to comment #2) > WebKitTools/Scripts/webkitpy/common/checkout/scm.py:211: deprecated form of > raising exception [pep8/W602] [5] Not sure what the correct form of raising an exception is, but this is certainly consistent with the bzillion other such cases in this file. Not fixing now. This should probably be fixed throughout the file at once.
Eric Seidel (no email)
Comment 4 2010-04-05 12:16:45 PDT
Comment on attachment 52551 [details] Patch OK.
Eric Seidel (no email)
Comment 5 2010-04-06 23:45:40 PDT
Attachment 52551 [details] was posted by a committer and has review+, assigning to Ojan Vafai for commit.
Ojan Vafai
Comment 6 2010-04-08 17:35:18 PDT
http://trac.webkit.org/changeset/57091
Note You need to log in before you can comment on or make changes to this bug.