Summary: | A few tests in fast/canvas/webgl failed randomly on Leopard Commit Bot | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||||||
Component: | Tools / Tests | Assignee: | Zhenyao Mo <zmo> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cmarrin, commit-queue, dglazkov, fishd, kbr, oliver | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Eric Seidel (no email)
2010-04-05 10:38:51 PDT
Created attachment 52768 [details] patch We turn off stencil/antialias by default for tests that create canvas dynamically. This should tremendously reduce the probability of test failure, hopefully next to zero. The true cause of these failures are very likely a driver bug in Mac where multi-threading competition is on. We could turn them on again when this driver bug is fixed. We filed another bug for this driver bug: https://bugs.webkit.org/show_bug.cgi?id=36972 Created attachment 52770 [details]
revised patch: fixed a typo
Comment on attachment 52770 [details]
revised patch: fixed a typo
The JS change need a FIXME comment next to it with a link to one of these bugs.
Also, why not just do if (!attrs) instead of checking for typeof == undefined?
(In reply to comment #3) > (From update of attachment 52770 [details]) > The JS change need a FIXME comment next to it with a link to one of these bugs. > I'll add it. Thanks. > Also, why not just do if (!attrs) instead of checking for typeof == undefined? The reason for using typeof==undefined instead of (!attrs) is the latter could be a intended null/0 input, whereas the former always indicates a default value situation. Created attachment 52779 [details]
revised patch: add a FIXME comment
(In reply to comment #5) > Created an attachment (id=52779) [details] > revised patch: add a FIXME comment Patch looks good. Please update the synopsis of this bug to match that in the ChangeLog. Comment on attachment 52779 [details] revised patch: add a FIXME comment Clearing flags on attachment: 52779 Committed r57234: <http://trac.webkit.org/changeset/57234> All reviewed patches have been landed. Closing bug. |