Bug 37083

Summary: [Qt] [Symbian] Remove obsolete build flags for Symbian
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, webkit.review.bot
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: S60 3rd edition   
Attachments:
Description Flags
proposed change none

Laszlo Gombos
Reported 2010-04-05 06:12:32 PDT
WebCore/config.h contains some obsolete code that was checked in r23281 3 years ago.
Attachments
proposed change (1.32 KB, patch)
2010-04-05 06:26 PDT, Laszlo Gombos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Laszlo Gombos
Comment 1 2010-04-05 06:26:52 PDT
Created attachment 52530 [details] proposed change
Kenneth Rohde Christiansen
Comment 2 2010-04-05 06:28:21 PDT
Comment on attachment 52530 [details] proposed change I'll trust you on this one.
WebKit Commit Bot
Comment 3 2010-04-05 06:47:42 PDT
Comment on attachment 52530 [details] proposed change Clearing flags on attachment: 52530 Committed r57074: <http://trac.webkit.org/changeset/57074>
WebKit Commit Bot
Comment 4 2010-04-05 06:47:47 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 5 2010-04-05 07:28:31 PDT
http://trac.webkit.org/changeset/57074 might have broken Leopard Intel Release (Tests)
Laszlo Gombos
Comment 6 2010-04-05 08:49:36 PDT
I do not think this commit changed anything for Leopard. The failed test seems to be a flaky xhr test that timed out. I'm happy to roll out the patch though if others thing otherwise.
Eric Seidel (no email)
Comment 7 2010-04-05 10:26:46 PDT
Sorry for the noise. Bug 37077 struck twice in a row. :(
Note You need to log in before you can comment on or make changes to this bug.