Bug 37064

Summary: check-webkit-style: refactor the option-parsing code
Product: WebKit Reporter: Chris Jerdonek <cjerdonek>
Component: Tools / TestsAssignee: Chris Jerdonek <cjerdonek>
Status: RESOLVED FIXED    
Severity: Normal CC: cjerdonek, commit-queue, hamaji
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch none

Chris Jerdonek
Reported 2010-04-03 14:06:27 PDT
There is some minor refactoring the option-parsing code could use. This includes one FIXME and some other things.
Attachments
Proposed patch (14.62 KB, patch)
2010-04-03 14:24 PDT, Chris Jerdonek 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Jerdonek
Comment 1 2010-04-03 14:24:45 PDT
Created attachment 52501 [details] Proposed patch
Shinichiro Hamaji
Comment 2 2010-04-04 00:15:40 PDT
Comment on attachment 52501 [details] Proposed patch Looks good!
WebKit Commit Bot
Comment 3 2010-04-04 00:44:24 PDT
Comment on attachment 52501 [details] Proposed patch Rejecting patch 52501 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 12625 test cases. fast/canvas/webgl/drawArraysOutOfBounds.html -> failed Exiting early after 1 failures. 5073 tests run. 88.37s total testing time 5072 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/1553245
Chris Jerdonek
Comment 4 2010-04-04 01:27:05 PDT
Comment on attachment 52501 [details] Proposed patch Clearing flags on attachment: 52501 Committed r57056: <http://trac.webkit.org/changeset/57056>
Chris Jerdonek
Comment 5 2010-04-04 01:27:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.