Bug 37056 – LayoutTests/editing/selection/move-left-right.html is slow

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Hajime Morrita]

It takes over 13 secs to finish on my Mac Pro. Should be take at most a few second.

[Hajime Morrita]

Created attachment 52478 [details]
patch v0

[Hajime Morrita]

Original test hide each test <div> after using it. 
The patch changes it to remove all <div>s at once when all tests done.
This reduce running time 13sec -> 3.2sec.

The expectation contains storange y values, which is due to Bug 37016, 
that is revealed by the change. But it is not bug of this test, nor bug of the code that the test exercises.

[Shinichiro Hamaji]

Comment on attachment 52478 [details]
patch v0

> The expectation contains storange y values, which is due to Bug 37016, 
> that is revealed by the change. But it is not bug of this test, nor bug of the
> code that the test exercises.

Is it easy to fix Bug 37016? If so, I'd suggest fixing it first.

> -            layoutTestController.dumpAsText();
> +            if (window.layoutTestController)
> +                layoutTestController.dumpAsText();

I think we usually put dumpAsText on the toplevel so we can call this even when runTest isn't called.

Anyway, this looks good!

[Eric Seidel (no email)]

Attachment 52478 [details] was posted by a committer and has review+, assigning to MORITA Hajime for commit.

[Hajime Morrita]

Committed r58048: <http://trac.webkit.org/changeset/58048>

[Shinichiro Hamaji]

You missed my comment? :)

[Hajime Morrita]

Committed r58113: <http://trac.webkit.org/changeset/58113>