Bug 37056

Summary: LayoutTests/editing/selection/move-left-right.html is slow
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: Tools / TestsAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, hamaji
Priority: P4    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch v0 none

Description Hajime Morrita 2010-04-02 22:14:58 PDT 
It takes over 13 secs to finish on my Mac Pro. Should be take at most a few second.
Comment 1 Hajime Morrita 2010-04-02 22:39:44 PDT 
Created attachment 52478 [details]
patch v0
Comment 2 Hajime Morrita 2010-04-02 22:43:39 PDT 
Original test hide each test <div> after using it. 
The patch changes it to remove all <div>s at once when all tests done.
This reduce running time 13sec -> 3.2sec.

The expectation contains storange y values, which is due to Bug 37016, 
that is revealed by the change. But it is not bug of this test, nor bug of the code that the test exercises.
Comment 3 Shinichiro Hamaji 2010-04-20 19:13:17 PDT 
Comment on attachment 52478 [details]
patch v0

> The expectation contains storange y values, which is due to Bug 37016, 
> that is revealed by the change. But it is not bug of this test, nor bug of the
> code that the test exercises.

Is it easy to fix Bug 37016? If so, I'd suggest fixing it first.

> -            layoutTestController.dumpAsText();
> +            if (window.layoutTestController)
> +                layoutTestController.dumpAsText();

I think we usually put dumpAsText on the toplevel so we can call this even when runTest isn't called.

Anyway, this looks good!
Comment 4 Eric Seidel (no email) 2010-04-21 18:14:36 PDT 
Attachment 52478 [details] was posted by a committer and has review+, assigning to MORITA Hajime for commit.
Comment 5 Hajime Morrita 2010-04-21 20:40:45 PDT 
Committed r58048: <http://trac.webkit.org/changeset/58048>
Comment 6 Shinichiro Hamaji 2010-04-21 21:46:24 PDT 
You missed my comment? :)
Comment 7 Hajime Morrita 2010-04-22 13:18:10 PDT 
Committed r58113: <http://trac.webkit.org/changeset/58113>