Summary: | [V8] Extend the set of types supported by SerializedScriptValue | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Vitaly Repeshko <vitalyr> | ||||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, commit-queue, eric, levin, pfeldman, webkit.review.bot, yurys | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Vitaly Repeshko
2010-04-02 17:37:31 PDT
Created attachment 52472 [details]
patch v1
Comment on attachment 52472 [details] patch v1 > - push(new ObjectState(handleCast<v8::Object>(value))); > - // FIXME: > - // - check not a wrapper > - // - support File, ImageData, etc. > - } > - return true; Please file a bug for the FIXME. > + static StateBase* newArrayState(v8::Handle<v8::Array> array, StateBase* next) > + { > + // FIXME: use plain Array state when we can quickly check that > + // an array is not sparse and has only indexed properties. > + return new SparseArrayState(array, next); > + } > + Ditto. > + static StateBase* newObjectState(v8::Handle<v8::Object> object, StateBase* next) > + { > + // FIXME: > + // - check not a wrapper > + // - support File, etc. > + return new ObjectState(object, next); > + } Ditto. (In reply to comment #0) > [V8] Extend the set of types supported by SerializedScriptValue Can we write unit tests for serialize script values? (In reply to comment #3) > (In reply to comment #0) > > [V8] Extend the set of types supported by SerializedScriptValue > > Can we write unit tests for serialize script values? We can, but most interesting stuff is already covered by existing layout tests. (See fast/dom/Window/window-postmessage*.) Created attachment 52539 [details]
patch v1.1: rebased
M WebCore/ChangeLog M WebCore/bindings/v8/SerializedScriptValue.cpp Committed r57079 http://trac.webkit.org/changeset/57079 might have broken Tiger Intel Release http://trac.webkit.org/changeset/57079 might have broken Tiger Intel Release bug 36798 seems to be the actual culprit. Sheriffbot should not have warned twice. http://trac.webkit.org/changeset/57079 might have broken Tiger Intel Release http://trac.webkit.org/changeset/57079 might have broken Tiger Intel Release Sorry for the repeated messages. I'm figuring out why he's spamming. The problem is vitalyr@chromium.org is not in committers.py. Fixing. Sorry, he's going to spam one more time when I bring him back online. http://trac.webkit.org/changeset/57079 might have broken Tiger Intel Release Comment on attachment 52539 [details] patch v1.1: rebased Reverted for crashing layout test in: fast/dom/Window/window-postmessage-clone.html = CRASH Committing to http://svn.webkit.org/repository/webkit/trunk M WebCore/ChangeLog M WebCore/bindings/v8/SerializedScriptValue.cpp Committed r57133 Reopening since has been rolled out. Created attachment 52625 [details]
patch v1.2: fixed delete bug in handleError
M WebCore/ChangeLog M WebCore/bindings/v8/SerializedScriptValue.cpp Committed r57145 |