Bug 37049

Summary: Change DatabaseAuthorizer to allow all fts2 functions
Product: WebKit Reporter: Dumitru Daniliuc <dumi>
Component: New BugsAssignee: Dumitru Daniliuc <dumi>
Severity: Normal CC: beidson, dglazkov, fishd, michaeln, mjs, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
patch beidson: review-, dumi: commit-queue-

Description Dumitru Daniliuc 2010-04-02 15:31:16 PDT
DatabaseAuthorizer is currently disallowing some fts2 functions. We need to fix that.
Comment 1 Dumitru Daniliuc 2010-04-02 17:09:02 PDT
Created attachment 52470 [details]
Comment 2 Brady Eidson 2010-04-02 17:17:23 PDT
It seems like an awful idea to introduce such fragmented capabilities between the WebKit browsers.

(Apple's Mac + Win builds don't support fts2).
Comment 3 Brady Eidson 2010-04-02 17:18:18 PDT
I'm overriding darin's r+ with an r- until we discuss this more.
Comment 4 Brady Eidson 2010-04-02 17:22:04 PDT
Mark pointed out that fts2 support was enabled in http://trac.webkit.org/changeset/54990

I think this change was a poor decision and needs a little more discussion.

(Yes, I see that I am CC'ed on https://bugs.webkit.org/show_bug.cgi?id=34867, and am sorry to have missed this.  My bad)
Comment 5 Dumitru Daniliuc 2010-04-02 17:25:18 PDT
If the only problem is that not all ports support the same modules/functions, then I can abstract out this function into its own class, provide a default WebKit implementation that allows (or maybe disallows?) everything, and implement a Chromium-specific version too.

Let me know how you want us to deal with this problem.
Comment 6 Brady Eidson 2010-04-02 17:37:21 PDT
No, I mean, to the end user (the web path author), some SQL works on one platform but doesn't work on another platform.  Such as FTS2.

The Web SQL Database spec is already at an impass.

Currently, SQLite in WebKit is pretty much the only realistic implementation of the spec.  Introducing further incompatibilities (such as FTS2 in one browser, but not another) would only fragment things further.
Comment 7 Dimitri Glazkov (Google) 2010-04-04 08:06:01 PDT
How hard would it be to bring fts2 to Safari?
Comment 8 Darin Fisher (:fishd, Google) 2010-04-04 11:37:52 PDT
A few months back, Sam mentioned that there was interest in adding FTS support to Safari.  Has that changed?

As for this bug, how about we add an ENABLE_SQLITE_FTS2 for now so that deciding the behavior of Safari does not have to be a pre-requisite to fixing a Chrome issue.  We are already shipping FTS2 in the latest stable release of Chrome.
Comment 9 Dumitru Daniliuc 2010-04-14 13:10:08 PDT
Ping. Any way we could submit a quick, temporary fix to this problem so that Chromium users can use FTS2?
Comment 10 Dumitru Daniliuc 2010-05-07 18:31:41 PDT
We're moving to FTS3, so this bug is obsolete.