Summary: | Update image results for SVG as CSS border image tests | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
Component: | SVG | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bdakin, eric, jparent, krit, xan.lopez, yael, zimmermann | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2010-04-02 10:16:01 PDT
fast/borders/svg-as-border-image.html also broken This was broken by http://trac.webkit.org/changeset/54865 I think the expected result is wrong, and the same is for fast/images/svg-as-tiled-background.html. The expected result of fast/borders/border-image-01.html shows that the image covers the whole div, so I don;t understand why this is not the case for SVG images. Yes, I think the expected image are wrong. I have some better tests to land. Created attachment 54678 [details]
Better tests (zip)
Nice tests! If you upload a patch, I'm happy to r+ them. *** Bug 35323 has been marked as a duplicate of this bug. *** Created attachment 54777 [details]
Patch
Comment on attachment 54777 [details]
Patch
r=me!
It makes no sense to me, but it seems the Gtk bot seems more likely to crash in worker tests after this change (which seems impossible to be related). We'll have to monitor and see if it's just a bot issue. I don't understand it, but we've had 4 worker crashes in a row on the Gtk bot starting on this commit. http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r58580%20(2832)/results.html http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r58582%20(2834)/results.html http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r58583%20(2836)/results.html http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r58584%20(2838)/results.html The Gtk bot seems to have righted itself and stopped being mad at the world. I'll follow up with Xan to see if we've seen this before/how we can avoid false-positives like this in the future. Attachment 54777 [details] was posted by a committer and has review+, assigning to Simon Fraser for commit.
This landed in http://trac.webkit.org/changeset/58580 |