Bug 37011

Summary: Position::primaryDirection() should not use its own accessor.
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P5    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
v0; small cleanup only none

Description Hajime Morrita 2010-04-01 22:23:45 PDT 
Position::primaryDirection() uses Position::node(), which should be replaced with accessing Position::m_anchorNode directly.
This bug is to take the feedback on Bug 36948, whose patch was accidentally landed before tiny cleanup.
Comment 1 Hajime Morrita 2010-04-01 22:28:16 PDT 
Created attachment 52379 [details]
v0; small cleanup only
Comment 2 Eric Seidel (no email) 2010-04-01 23:41:41 PDT 
Comment on attachment 52379 [details]
v0; small cleanup only

Why is this better?
Comment 3 Alexey Proskuryakov 2010-04-02 16:21:06 PDT 
Comment on attachment 52379 [details]
v0; small cleanup only

r=me

That's just the preferred style. One thing this helps with is making debugging easier - you don't need to step into accessor functions that much.
Comment 4 WebKit Commit Bot 2010-04-02 17:38:34 PDT 
Comment on attachment 52379 [details]
v0; small cleanup only

Clearing flags on attachment: 52379

Committed r57037: <http://trac.webkit.org/changeset/57037>
Comment 5 WebKit Commit Bot 2010-04-02 17:38:38 PDT 
All reviewed patches have been landed.  Closing bug.