Bug 37011 - Position::primaryDirection() should not use its own accessor.
Summary: Position::primaryDirection() should not use its own accessor.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P5 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-01 22:23 PDT by Hajime Morrita
Modified: 2010-04-02 17:38 PDT (History)
1 user (show)

See Also:


Attachments
v0; small cleanup only (1.27 KB, patch)
2010-04-01 22:28 PDT, Hajime Morrita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2010-04-01 22:23:45 PDT
Position::primaryDirection() uses Position::node(), which should be replaced with accessing Position::m_anchorNode directly.
This bug is to take the feedback on Bug 36948, whose patch was accidentally landed before tiny cleanup.
Comment 1 Hajime Morrita 2010-04-01 22:28:16 PDT
Created attachment 52379 [details]
v0; small cleanup only
Comment 2 Eric Seidel (no email) 2010-04-01 23:41:41 PDT
Comment on attachment 52379 [details]
v0; small cleanup only

Why is this better?
Comment 3 Alexey Proskuryakov 2010-04-02 16:21:06 PDT
Comment on attachment 52379 [details]
v0; small cleanup only

r=me

That's just the preferred style. One thing this helps with is making debugging easier - you don't need to step into accessor functions that much.
Comment 4 WebKit Commit Bot 2010-04-02 17:38:34 PDT
Comment on attachment 52379 [details]
v0; small cleanup only

Clearing flags on attachment: 52379

Committed r57037: <http://trac.webkit.org/changeset/57037>
Comment 5 WebKit Commit Bot 2010-04-02 17:38:38 PDT
All reviewed patches have been landed.  Closing bug.