Bug 36995

Summary: Improve the error handling in rollout a bit
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Adam Barth
Reported 2010-04-01 17:43:51 PDT
Improve the error handling in rollout a bit
Attachments
Patch (11.40 KB, patch)
2010-04-01 17:53 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (10.42 KB, patch)
2010-04-01 18:53 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (10.66 KB, patch)
2010-04-01 20:49 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-04-01 17:53:02 PDT
Created attachment 52360 [details] Patch
Adam Barth
Comment 2 2010-04-01 18:50:58 PDT
Comment on attachment 52360 [details] Patch dave_levin broke my patch. Will re-spin.
Adam Barth
Comment 3 2010-04-01 18:53:59 PDT
Created attachment 52365 [details] Patch
Eric Seidel (no email)
Comment 4 2010-04-01 20:36:47 PDT
Comment on attachment 52365 [details] Patch Explain why in your comment, please: # Note: Don't print a bug URL here because it will confuse the 259 # SheriffBot. Yes, that's lame. 260 log("Preparing rollout for bug %s." % commit_info.bug_id()) 261 cc_list? 267 cc = sorted([party.bugzilla_email() We should be passing around lists instead of a string: 273 "bug_cc": ",".join(cc), Anyway, this looks fine. We should fix the cc passing around at some point. Ideally now, but not required. Either way I don't need to see this again.
Adam Barth
Comment 5 2010-04-01 20:49:56 PDT
Created attachment 52370 [details] Patch for landing
Adam Barth
Comment 6 2010-04-01 21:32:01 PDT
Comment on attachment 52370 [details] Patch for landing Clearing flags on attachment: 52370 Committed r56964: <http://trac.webkit.org/changeset/56964>
Adam Barth
Comment 7 2010-04-01 21:32:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.