Bug 36980

Summary: Add object addresses to debug showLayerTree() output.
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
Attachments:
Description Flags
Patch darin: review+

Simon Fraser (smfr)
Reported 2010-04-01 14:03:49 PDT
It would be useful if showLayerTree() when called from gdb showed the object addresses.
Attachments
Patch (7.27 KB, patch)
2010-04-01 14:18 PDT, Simon Fraser (smfr) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2010-04-01 14:18:46 PDT
Created attachment 52334 [details] Patch
Darin Adler
Comment 2 2010-04-01 16:16:39 PDT
Comment on attachment 52334 [details] Patch > + if (behavior & RenderAsTextShowAddresses) > + ts << " " << static_cast<const void*>(&o); What happens if you don't do the static_cast? Does it fail to compile? Can you leave the cast out? r=me
Simon Fraser (smfr)
Comment 3 2010-04-01 16:46:20 PDT
I was able to remove the casts! http://trac.webkit.org/changeset/56948
Note You need to log in before you can comment on or make changes to this bug.