Bug 36977

Summary:

aria-label doesn't work on image map area

Product:

WebKit

Reporter:

chris fleizach <cfleizach>

Component:

Accessibility

Assignee:

chris fleizach <cfleizach>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, bdakin, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

37006

Bug Blocks:

Attachments:

Description	Flags
patch	none

Description chris fleizach 2010-04-01 12:35:04 PDT

@aria-label value should be recognized as the label, but it's only determined from @alt

Comment 1 chris fleizach 2010-04-01 12:38:10 PDT

Created attachment 52322 [details]
patch

Comment 2 chris fleizach 2010-04-01 12:46:50 PDT

http://trac.webkit.org/changeset/56930

Comment 3 Eric Seidel (no email) 2010-04-01 21:33:15 PDT

This test looks to be very flaky judging by bug 37005.

Comment 4 Adam Barth 2010-04-01 21:39:04 PDT

Committed r56965: <http://trac.webkit.org/changeset/56965>

Comment 5 Adam Barth 2010-04-01 21:40:04 PDT

Rolled out because this caused aria-liveregions-notifications to become very flaky (or at least that's our best guess).

Comment 6 chris fleizach 2010-04-01 21:45:59 PDT

i have a hard time believing this test is causing flakiness.

Comment 7 Adam Barth 2010-04-01 21:48:16 PDT

You're welcome to look at the buildbot logs.  It's the only accessibility related change near when the test started to become flaky.  We might well be wrong, in which case we can roll it back in.

Comment 8 chris fleizach 2010-04-06 14:29:37 PDT

re-added patch now that leopard release is not running aria-live-region-notification test, which failed last time this was added. that test is the flaky one, and this patch does not affect that code path. so no reason to stop legitimate development

http://trac.webkit.org/changeset/57167

Comment 9 Eric Seidel (no email) 2010-04-06 19:30:33 PDT

This test failed on Snow Leopard again just now:
http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r57184%20(5687)/platform/mac/accessibility/aria-liveregions-notifications-diffs.txt

Sorry for commenting on 3 bugs, not sure which one is actually the active one.

Comment 10 chris fleizach 2010-04-06 20:31:47 PDT

i'll see if i can make a less flaky test tonite

(In reply to comment #9)
> This test failed on Snow Leopard again just now:
> http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r57184%20(5687)/platform/mac/accessibility/aria-liveregions-notifications-diffs.txt
> 
> Sorry for commenting on 3 bugs, not sure which one is actually the active one.

Comment 11 Adam Barth 2010-04-07 00:04:50 PDT

(In reply to comment #8)
> re-added patch now that leopard release is not running
> aria-live-region-notification test, which failed last time this was added. that
> test is the flaky one, and this patch does not affect that code path. so no
> reason to stop legitimate development

There is some interaction between your patch and that test because without your patch the test passes consistently but with your patch, the test fails intermittently.  Perhaps we should try to understand the interaction before disabling tests?