Bug 36963

Summary:

[GTK] pointerCursor should use the default cursor set for the window, not GDK_LEFT_PTR

Product:

WebKit

Reporter:

Gustavo Noronha (kov) <gustavo>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, webkit.review.bot

Priority:

Keywords:

Gtk

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
This is not a joke.	gustavo: commit-queue-
remove assert, as discussed with xan	xan.lopez: review+, gustavo: commit-queue-

Gustavo Noronha (kov)

Reported 2010-04-01 08:48:11 PDT

While playing with cursors, I found out that if I set a cursor to a window that hosts a WebKitWebView, it will be disregarded. Also, even if it is set explicitely on the WebKitWebView widget, it will go back to being the white pointer after it has changed into something else, and back. It should likely not use GDK_LEFT_PTR explicitely.

Attachments
This is not a joke. (1.96 KB, patch) 2010-04-01 08:52 PDT, Gustavo Noronha (kov)	gustavo: commit-queue-	Details Formatted Diff Diff
remove assert, as discussed with xan (1.99 KB, patch) 2010-04-22 06:44 PDT, Gustavo Noronha (kov)	xan.lopez: review+ gustavo: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Gustavo Noronha (kov)

Comment 1 2010-04-01 08:52:08 PDT

Created attachment 52300 [details] This is not a joke.

WebKit Review Bot

Comment 2 2010-04-01 08:57:25 PDT

Attachment 52300 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/platform/gtk/CursorGtk.cpp:93: Use 0 instead of NULL. [readability/null] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Eric Seidel (no email)

Comment 3 2010-04-01 16:08:28 PDT

What about when a website specifies pointer cursor over a specific region? Won't this change cause those sites to break?

Gustavo Noronha (kov)

Comment 4 2010-04-19 11:26:44 PDT

(In reply to comment #3) > What about when a website specifies pointer cursor over a specific region? > Won't this change cause those sites to break? It should not. What the change does is make sure that when the web site requests 'pointer', that the cursor will become whatever the user (or the application) has chosen the pointer cursor to be, so I believe that is the correct behaviour.

Gustavo Noronha (kov)

Comment 5 2010-04-22 06:44:37 PDT

Created attachment 54056 [details] remove assert, as discussed with xan

WebKit Review Bot

Comment 6 2010-04-22 06:49:55 PDT

Attachment 54056 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/gtk/CursorGtk.cpp:92: Use 0 instead of NULL. [readability/null] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Xan Lopez

Comment 7 2010-04-27 09:52:05 PDT

Comment on attachment 54056 [details] remove assert, as discussed with xan r=me

Gustavo Noronha (kov)

Comment 8 2010-04-29 12:42:25 PDT

Landed as r58531.

Note You need to log in before you can comment on or make changes to this bug.