Bug 36955

Summary:

check-webkit-style should support --git-index

Product:

WebKit

Reporter:

Hajime Morrita <morrita>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

hamaji

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
patch v0	hamaji: review-

Hajime Morrita

Reported 2010-04-01 05:46:00 PDT

check-webkit-style should support --git-index like prepare-ChangeLog does. With --git-index, checker will inspect diff from git index.

Attachments
patch v0 (9.40 KB, patch) 2010-04-01 05:53 PDT, Hajime Morrita	hamaji: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Hajime Morrita

Comment 1 2010-04-01 05:53:52 PDT

Created attachment 52290 [details] patch v0

Shinichiro Hamaji

Comment 2 2010-04-01 06:58:16 PDT

Comment on attachment 52290 [details] patch v0 Thanks for your effort! However, I think this feature can confuse users. Please see the discussion in Bug 27955 for detail. Bug 35781 is also related. David's comment #9 in Bug 35781 would be super helpful to understand why it's difficult for us to support this syntax.

Shinichiro Hamaji

Comment 3 2010-04-01 06:58:31 PDT

*** This bug has been marked as a duplicate of bug 27955 ***

Hajime Morrita

Comment 4 2010-04-01 17:57:07 PDT

Hamaji-san, thank you for reviewing. I should search bugzilla before file this... I'm sorry to bother you.

Note You need to log in before you can comment on or make changes to this bug.