| Summary: | Refactoring: Position::primaryDirection() should be extracted. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Hajime Morrita <morrita> | ||||
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap, commit-queue, hamaji, mitz | ||||
| Priority: | P3 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Hajime Morrita
2010-04-01 04:47:12 PDT
Created attachment 52285 [details]
patch v0
Comment on attachment 52285 [details]
patch v0
Nice!
Comment on attachment 52285 [details] patch v0 Clearing flags on attachment: 52285 Committed r56915: <http://trac.webkit.org/changeset/56915> All reviewed patches have been landed. Closing bug. Comment on attachment 52285 [details] patch v0 Rejecting patch 52285 from commit-queue. Unexpected failure when landing patch! Please file a bug against webkit-patch. Failed to run "['WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--non-interactive', '--build-style=both', '--quiet', '52285', '--parent-command=commit-queue', '--no-update']" exit_code: 1 Last 500 characters of output: cgi?id=52285&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=36948&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Processing patch 52285 from bug 36948. NOBODY (OOPS!) found in /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /Users/eseidel/Projects/CommitQueue/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). It's definitely a great change to extract this code into a function. But I'm not sure if Position is a good place for it. Of all data members in Position, this code only uses m_node, so I wonder if direction is conceptually a function of position. It's also easy to confuse with VisiblePosition affinity.
On the other hand, it's only used in Position and VisiblePosition code. Hmm.
+ for (const RenderObject* r = node()->renderer(); r; r = r->parent()) {
We don't usually use accessor functions in class implementation, should preferably be m_anchorNode->renderer().
Comment on attachment 52285 [details]
patch v0
Looks like cq+ was just set prematurely.
|