Summary: | [Qt] REGRESSION(r56869): Windows build is broken | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> | ||||||||
Component: | New Bugs | Assignee: | QtWebKit Unassigned <webkit-qt-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Blocker | CC: | abarth, dimich, eric, jianli, jturcotte, webkit.review.bot | ||||||||
Priority: | P1 | Keywords: | Qt | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Windows XP | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 36472 | ||||||||||
Attachments: |
|
Description
Csaba Osztrogonác
2010-03-31 22:22:36 PDT
Created attachment 52259 [details]
proposed fix
Missing "LIBS += -lOle32" added.
Missing ARRAYSIZE macro definition added if it isn't defined before. (copied from:
\Program Files\Microsoft Platform SDK for Windows Server 2003 R2\Include\CeLib.h)
Attachment 52259 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/UUID.cpp:39: Missing spaces around / [whitespace/operators] [3]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 52260 [details]
proposed fix
style fixed
I see ARRAYSIZE_UNSAFE in: http://trac.webkit.org/changeset/53634 I thought we had an ARRAYSIZE macro in wtf/StdLibExtras.h, but we don't seem to. Comment on attachment 52260 [details]
proposed fix
r=me
(In reply to comment #5) > (From update of attachment 52260 [details]) > r=me Landed in http://trac.webkit.org/changeset/56922 Created attachment 55097 [details]
WinCE buildfix
WinCE build is broken too, fix attached here. See comments in https://bugs.webkit.org/show_bug.cgi?id=36472 Comment on attachment 55097 [details]
WinCE buildfix
rs=me
(In reply to comment #9) > (From update of attachment 55097 [details]) > rs=me Landed in http://trac.webkit.org/changeset/58813 http://trac.webkit.org/changeset/58813 might have broken Qt Linux Release |